Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat marker intersection more symmetrically #384

Merged
merged 2 commits into from
May 30, 2022
Merged

Treat marker intersection more symmetrically #384

merged 2 commits into from
May 30, 2022

Conversation

dimbleby
Copy link
Contributor

The somewhat elaborate real-life example that motivated this change is given as a testcase.

But on further consideration, this is also a symmetry improvement: both union.intersect(intersection) and intersection.intersect(union) now behave the same way (preferring to return a union),

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neersighted neersighted merged commit 3eccdb8 into python-poetry:main May 30, 2022
@radoering radoering mentioned this pull request May 31, 2022
Closed
@dimbleby dimbleby deleted the prefer-marker-union branch May 31, 2022 07:41
@radoering radoering mentioned this pull request Jul 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimbleby @neersighted